Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(triplestore): Use N-Quads instead of TriG for repository upgrade (DSP-1129) #1767

Merged
merged 10 commits into from Dec 3, 2020
Merged

enhancement(triplestore): Use N-Quads instead of TriG for repository upgrade (DSP-1129) #1767

merged 10 commits into from Dec 3, 2020

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Dec 2, 2020 •
edited

resolves DSP-1129

  • Add N-Quads support to the RDF API.
  • Use N-Quads for uploading and downloading the repository in HttpTriplestoreConnector and RepositoryUpdater.
  • Fix a bug in RepositoryUpdater that caused plugins to be run out of order.
  • Have RdfFormatUtil close streams when possible, so the caller doesn't have to.
  • Correctly convert empty blank nodes from an RdfModel to JSON-LD.
  • Add tests.

@benjamingeer benjamingeer marked this pull request as draft December 2, 2020 11:18
@benjamingeer benjamingeer self-assigned this Dec 2, 2020
@benjamingeer benjamingeer added API/Admin API/V2 enhancement improve existing code or new feature and removed API/Admin API/V2 labels Dec 2, 2020
@benjamingeer benjamingeer marked this pull request as ready for review December 3, 2020 08:47
SepidehAlassi
SepidehAlassi approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for implementing it.

@benjamingeer
Copy link
Author

Thanks for the review!

@benjamingeer benjamingeer merged commit a02ac50 into main Dec 3, 2020
@benjamingeer benjamingeer deleted the wip/DSP-1129-large-rdf-files branch December 3, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SepidehAlassi SepidehAlassi SepidehAlassi approved these changes

Assignees

@benjamingeer benjamingeer

Labels
enhancement improve existing code or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benjamingeer @SepidehAlassi