Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use java.nio.file.Path instead of java.io.File (DSP-1124) #1770

Merged
merged 4 commits into from Dec 7, 2020
Merged

refactor: Use java.nio.file.Path instead of java.io.File (DSP-1124) #1770

merged 4 commits into from Dec 7, 2020

Conversation

benjamingeer
Copy link

resolves DSP-1124

@benjamingeer benjamingeer added the chore maintenance and build tasks label Dec 4, 2020
@benjamingeer benjamingeer self-assigned this Dec 4, 2020
@benjamingeer benjamingeer marked this pull request as draft December 4, 2020 15:35
@benjamingeer benjamingeer marked this pull request as ready for review December 7, 2020 07:32
SepidehAlassi
SepidehAlassi approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you.

@benjamingeer benjamingeer merged commit 74223d0 into main Dec 7, 2020
@benjamingeer benjamingeer deleted the wip/DSP-1124-java-nio branch December 7, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SepidehAlassi SepidehAlassi SepidehAlassi approved these changes

Assignees

@benjamingeer benjamingeer

Labels
chore maintenance and build tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benjamingeer @SepidehAlassi