chore(gh-ci): CI is failing to test upgrade correctly (DSP-667)

[subotic]

• resolves DSP-667
• relsolves DSP-1113
• refactor: move IT tests to "test" folder
• remove KnoraSipiScriptsV1ITSpec.scala (see DSP-707 for explanation)

[benjamingeer]

Thanks very much, this is a big improvement. Could we also get rid of salsah1/src/test/scala/org/knora/salsah/TestContainers.scala?

[subotic]

Could we also get rid of salsah1/src/test/scala/org/knora/salsah/TestContainers.scala?

Hmm, the salsah1 tree is completely independent of the webapi tree, i.e., nothing is shared. If we break this isolation, then it will be more work to maintain the whole thing. Any changes in webapi could then potentially break something in salsah1. Maybe it would be better to extract salsah1 out of the dsp-api repository?

[benjamingeer]

Maybe it would be better to extract salsah1 out of the dsp-api repository?

You're right, that makes more sense. Would you rather make another PR for that?

[subotic]

Maybe it would be better to extract salsah1 out of the dsp-api repository?

You're right, that makes more sense. Would you rather make another PR for that?

yes, I can make another PR for that.