Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-v2): Update subclasses in ontology cache when base class changes (DSP-1643) #1860

Merged
merged 5 commits into from May 19, 2021

Conversation

@benjamingeer
Copy link
Contributor

@benjamingeer benjamingeer commented May 18, 2021

resolves DSP-1643

@benjamingeer benjamingeer self-assigned this May 18, 2021
@@ -1943,7 +1943,14 @@ object Cardinality extends Enumeration {
* @param guiOrder the SALSAH GUI order.
*/
case class KnoraCardinalityInfo(cardinality: Value, guiOrder: Option[Int] = None) {
override def toString: String = cardinality.toString
override def toString: String = guiOrder match {
case Some(definedGuiOrder) => s"$cardinality (guiOrder $definedGuiOrder)"

This comment has been minimized.

@SepidehAlassi

SepidehAlassi May 18, 2021
Contributor

nice.

@benjamingeer benjamingeer requested a review from SepidehAlassi May 19, 2021
Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

this is great, thanks.

@benjamingeer
Copy link
Contributor Author

@benjamingeer benjamingeer commented May 19, 2021

Thanks for your help and for the review!

@benjamingeer benjamingeer merged commit beb951d into main May 19, 2021
11 checks passed
11 checks passed
@github-actions
Build Everything
Details
@github-actions
Prepare next release
Details
@github-actions
Test client-test-data
Details
@github-actions
API Unit Tests
Details
@github-actions
API E2E Tests
Details
@github-actions
API Integration Tests
Details
@github-actions
Upgrade Integration Tests
Details
@github-actions
Docs Build Test
Details
@github-actions
Publish (on release only)
Details
@github-actions
Deploy docs (on release only)
Details
@github-actions
Google chat notification about release and published version
Details
@benjamingeer benjamingeer deleted the fix/DSP-1643-ontology-cache branch May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants