New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(audio): remove not required properties #2070
refactor(audio): remove not required properties #2070
Conversation
This reverts commit 2922bf7.
…i-and-js-lib-similar-to-moving-image-file-value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the changes in TTL files, which I see not directly related to removal duration information from audio.
…i-and-js-lib-similar-to-moving-image-file-value
As the data inside the triplestore has changed (duration property removed), the responses from the triplestore have also changed. The order in which the triplestore returns is data is arbitrary. That's why the changes inside the generated files are mixed up. |
…i-and-js-lib-similar-to-moving-image-file-value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
…i-and-js-lib-similar-to-moving-image-file-value
Kudos, SonarCloud Quality Gate passed!
|
Resolves DEV-
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information