Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve validation of GUI elements and GUI attributes (DEV-1082) #2098

Merged
merged 33 commits into from Jul 29, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Jul 19, 2022

Resolves DEV-1082

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert self-assigned this Jul 19, 2022
@irinaschubert irinaschubert changed the title refactor: Explore NewTypes and improve validation of GUI elements (DEV-1082) refactor: Improve validation of GUI elements and GUI attributes (DEV-1082) Jul 21, 2022
@irinaschubert irinaschubert marked this pull request as ready for review July 26, 2022 14:40
@irinaschubert irinaschubert requested a review from mpro7 July 26, 2022 14:42
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments have already become obsolete; others are cosmetic... feel free to do with them as you think best

docs/02-knora-ontologies/salsah-gui.md Outdated Show resolved Hide resolved
docs/02-knora-ontologies/salsah-gui.md Outdated Show resolved Hide resolved
docs/02-knora-ontologies/salsah-gui.md Outdated Show resolved Hide resolved
docs/02-knora-ontologies/salsah-gui.md Outdated Show resolved Hide resolved
docs/02-knora-ontologies/salsah-gui.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to apply my suggestions.
Also in docs you're using GUI and somewhere gui. To make it consistent, you should stick to capital version, since it's an acronym. It also make it more readable.

docs/02-knora-ontologies/salsah-gui.md Outdated Show resolved Hide resolved
docs/02-knora-ontologies/salsah-gui.md Outdated Show resolved Hide resolved
dsp-shared/src/main/scala/dsp/valueobjects/Schema.scala Outdated Show resolved Hide resolved
dsp-shared/src/main/scala/dsp/valueobjects/Schema.scala Outdated Show resolved Hide resolved
dsp-shared/src/main/scala/dsp/valueobjects/Schema.scala Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit 5cec8ba into main Jul 29, 2022
12 checks passed
@irinaschubert irinaschubert deleted the wip/dev-1082-explore-newtypes branch July 29, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants