Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Settings with AppConfig (DEV-1312) #2202

merged 45 commits into from Sep 20, 2022


Copy link

@irinaschubert irinaschubert commented Sep 12, 2022

Issue Number: DEV-1312

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

Copy link

swarmia bot commented Sep 12, 2022

✅  Linked to Story DEV-1312 · DSP-API: Remove settings and use AppConfig instead
➡️  Part of Epic DEV-542 · DSP-API Cleanups

@irinaschubert irinaschubert self-assigned this Sep 12, 2022
@irinaschubert irinaschubert changed the title refactor: Replace settings with appconfig (DEV-1312) refactor: Replace Settings with AppConfig (DEV-1312) Sep 12, 2022
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 86.64% // Head: 86.86% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (b7f3e65) compared to base (71c772f).
Patch coverage: 78.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2202      +/-   ##
+ Coverage   86.64%   86.86%   +0.22%     
  Files         233      241       +8     
  Lines       28020    28001      -19     
+ Hits        24277    24324      +47     
+ Misses       3743     3677      -66     
Impacted Files Coverage Δ
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 84.05% <0.00%> (-1.45%) ⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...sponder/projectsmessages/ProjectsMessagesADM.scala 91.19% <ø> (ø)
...tore/triplestoremessages/TriplestoreMessages.scala 74.78% <ø> (-0.22%) ⬇️
...webapi/messages/util/ConstructResponseUtilV2.scala 93.29% <ø> (ø)
...a/org/knora/webapi/messages/util/MessageUtil.scala 36.66% <ø> (ø)
...vsearch/types/GravsearchTypeInspectionRunner.scala 100.00% <ø> (ø)
.../webapi/messages/v2/responder/KnoraRequestV2.scala 0.00% <ø> (ø)
...webapi/messages/v2/responder/KnoraResponseV2.scala 85.18% <ø> (ø)
...s/v2/responder/listsmessages/ListsMessagesV2.scala 90.54% <ø> (ø)
... and 123 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irinaschubert irinaschubert marked this pull request as ready for review September 19, 2022 08:45
Copy link

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If the thing with the test setup that requires repo but no IIIF would make the tests faster, that would be even nicer... but so far so good

Copy link

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just check detailed comments below.

@irinaschubert irinaschubert merged commit 9b76417 into main Sep 20, 2022
@irinaschubert irinaschubert deleted the wip/dev-1312-replace-settings-with-appconfig branch September 20, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants