New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: change all project IRIs to contain UUID instead of shortcode (DEV-1400) #2255
Conversation
✅ Linked to Story DEV-1400 · DSP-API: Fix project IRIs |
Codecov ReportBase: 86.85% // Head: 86.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
==========================================
+ Coverage 86.85% 86.91% +0.05%
==========================================
Files 241 242 +1
Lines 27967 28057 +90
==========================================
+ Hits 24292 24385 +93
+ Misses 3675 3672 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not the most fun PR to review...
webapi/src/test/scala/org/knora/webapi/it/v2/StandoffRouteV2ITSpec.scala
Outdated
Show resolved
Hide resolved
.../test/scala/org/knora/webapi/store/triplestore/upgrade/plugins/UpgradePluginPR2255Spec.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions, please see my comments.
Issue Number: DEV-1400
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?
Other information