Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change all project IRIs to contain UUID instead of shortcode (DEV-1400) #2255

Merged
merged 29 commits into from Oct 27, 2022

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Oct 18, 2022

Issue Number: DEV-1400

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@mpro7 mpro7 self-assigned this Oct 18, 2022
@swarmia
Copy link

swarmia bot commented Oct 18, 2022

✅  Linked to Story DEV-1400 · DSP-API: Fix project IRIs
➡️  Part of Epic DEV-1403 · Project UUIDs

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 86.85% // Head: 86.91% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (1113a42) compared to base (c5c98ce).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
+ Coverage   86.85%   86.91%   +0.05%     
==========================================
  Files         241      242       +1     
  Lines       27967    28057      +90     
==========================================
+ Hits        24292    24385      +93     
+ Misses       3675     3672       -3     
Impacted Files Coverage Δ
...c/main/scala/org/knora/webapi/core/AppServer.scala 89.55% <ø> (ø)
...ages/util/search/gravsearch/GravsearchParser.scala 68.13% <0.00%> (-0.26%) ⬇️
...webapi/responders/admin/ProjectsResponderADM.scala 92.01% <ø> (ø)
...ora/webapi/responders/v2/OntologyResponderV2.scala 91.53% <ø> (ø)
...knora/webapi/responders/v2/SearchResponderV2.scala 90.95% <ø> (ø)
...scala/org/knora/webapi/routing/Authenticator.scala 88.88% <ø> (-0.08%) ⬇️
...org/knora/webapi/routing/admin/FilesRouteADM.scala 84.61% <ø> (ø)
...ebapi/store/cache/impl/CacheServiceInMemImpl.scala 100.00% <ø> (ø)
...a/webapi/store/iiif/impl/IIIFServiceSipiImpl.scala 84.76% <ø> (ø)
.../store/triplestore/TriplestoreServiceManager.scala 69.56% <ø> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpro7 mpro7 changed the title add test data refactor!: change all project IRIs to contain UUID instead of shortcode (DEV-1400) Oct 25, 2022
@mpro7 mpro7 marked this pull request as ready for review October 25, 2022 14:09
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not the most fun PR to review...

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions, please see my comments.

@mpro7 mpro7 merged commit f2b2584 into main Oct 27, 2022
8 checks passed
@mpro7 mpro7 deleted the DEV-1400-dsp-api-fix-project-iris branch October 27, 2022 13:05
@daschbot daschbot mentioned this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants