Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't log hashes (DEV-1442) #2265

merged 1 commit into from Oct 24, 2022


Copy link

@irinaschubert irinaschubert commented Oct 24, 2022

Issue Number: DEV-1442

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@irinaschubert irinaschubert self-assigned this Oct 24, 2022
Copy link

swarmia bot commented Oct 24, 2022

✅  Linked to Bug DEV-1442 · DSP-API: password hashes are logged

@irinaschubert irinaschubert marked this pull request as ready for review October 24, 2022 09:34
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 86.85% // Head: 86.85% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5f90fe8) compared to base (c5c98ce).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2265      +/-   ##
- Coverage   86.85%   86.85%   -0.01%     
  Files         241      241              
  Lines       27967    27984      +17     
+ Hits        24292    24306      +14     
- Misses       3675     3678       +3     
Impacted Files Coverage Δ
...ages/util/search/gravsearch/GravsearchParser.scala 68.13% <0.00%> (-0.26%) ⬇️
...ora/webapi/responders/v2/OntologyResponderV2.scala 91.53% <ø> (ø) 84.61% <ø> (ø)
...n/scala/org/knora/webapi/routing/HealthRoute.scala 69.81% <50.00%> (-1.89%) ⬇️
...g/knora/webapi/store/iiif/IIIFServiceManager.scala 70.00% <75.00%> (ø)
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 84.50% <100.00%> (+0.44%) ⬆️
...min/responder/usersmessages/UsersMessagesADM.scala 79.36% <100.00%> (+0.22%) ⬆️
...ra/webapi/responders/admin/UsersResponderADM.scala 89.94% <100.00%> (+0.22%) ⬆️
...r/permissionsmessages/PermissionsMessagesADM.scala 86.39% <0.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@irinaschubert irinaschubert merged commit adaf4b0 into main Oct 24, 2022
8 checks passed
@irinaschubert irinaschubert deleted the wip/dev-1442-password-hashes-in-logs branch October 24, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants