Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove warning which considers v2 as not production ready #2282

Merged
merged 1 commit into from Nov 10, 2022

Conversation

seakayone
Copy link
Collaborator

Issue Number: DEV-

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failed for some reason, but once that's taken care of, you're good to merge

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 86.85% // Head: 86.99% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (68110db) compared to base (c5c98ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   86.85%   86.99%   +0.13%     
==========================================
  Files         241      242       +1     
  Lines       27967    28067     +100     
==========================================
+ Hits        24292    24416     +124     
+ Misses       3675     3651      -24     
Impacted Files Coverage Δ
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <ø> (ø)
...c/main/scala/org/knora/webapi/core/AppServer.scala 89.55% <ø> (ø)
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 94.18% <100.00%> (-0.14%) ⬇️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 89.85% <100.00%> (+5.79%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/Id.scala 65.38% <0.00%> (-3.85%) ⬇️
...n/scala/org/knora/webapi/routing/HealthRoute.scala 69.81% <0.00%> (-1.89%) ⬇️
...r/permissionsmessages/PermissionsMessagesADM.scala 86.39% <0.00%> (-0.32%) ⬇️
...ages/util/search/gravsearch/GravsearchParser.scala 68.13% <0.00%> (-0.26%) ⬇️
...scala/org/knora/webapi/routing/Authenticator.scala 88.88% <0.00%> (-0.08%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  • what is docu in PR title? use one of listed prefixes here,
  • have you already went thorough all you wanted to in the docs? Maybe if you are are going through anyway, you will find more things to improve, so I would say keep this branch as opened draft?

@BalduinLandolt
Copy link
Collaborator

ah yes, @mpro7 is right, prefix should be docs. Also, I re-ran the failing test, sometimes that's enough.

@seakayone seakayone changed the title docu: Remove warning which considers v2 as not production ready docs: Remove warning which considers v2 as not production ready Nov 9, 2022
@seakayone seakayone merged commit 0246522 into main Nov 10, 2022
@seakayone seakayone deleted the wip/remove-v2-warning branch November 10, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants