Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add stack-without-app target #2324

merged 4 commits into from Dec 7, 2022

chore: add stack-without-app target #2324

merged 4 commits into from Dec 7, 2022


Copy link

@mpro7 mpro7 commented Dec 6, 2022

Pull Request Checklist

Task Description/Number

It's bringing back the functionality of stack-up target, basically running only backend stack.

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@mpro7 mpro7 self-assigned this Dec 6, 2022
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 86.95% // Head: 86.64% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (8e237ed) compared to base (bfe578a).
Patch coverage: 57.69% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2324      +/-   ##
- Coverage   86.95%   86.64%   -0.31%     
  Files         242      251       +9     
  Lines       28102    28266     +164     
+ Hits        24435    24491      +56     
- Misses       3667     3775     +108     
Impacted Files Coverage Δ
...ain/scala/dsp/project/handler/ProjectHandler.scala 100.00% <ø> (ø)
.../src/main/scala/dsp/role/handler/RoleHandler.scala 88.00% <ø> (ø)
...c/main/scala/dsp/role/repo/impl/RoleRepoLive.scala 100.00% <ø> (ø)
...shared/src/main/scala/dsp/util/UuidGenerator.scala 0.00% <0.00%> (ø)
...erface/src/main/scala/dsp/user/route/GetUser.scala 0.00% <0.00%> (ø)
...ce/src/main/scala/dsp/user/route/MigrateUser.scala 0.00% <0.00%> (ø)
...ace/src/main/scala/dsp/user/route/UserRoutes.scala 0.00% <0.00%> (ø)
...c/main/scala/dsp/user/repo/impl/UserRepoLive.scala 100.00% <ø> (ø)
...sp-shared/src/main/scala/dsp/valueobjects/Id.scala 69.23% <66.66%> (+3.84%) ⬆️
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.81% <66.66%> (-0.87%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpro7 mpro7 changed the title chore: add stack-up-without-app target chore: add stack-without-app target Dec 7, 2022
@mpro7 mpro7 merged commit 5ec3223 into main Dec 7, 2022
10 checks passed
@mpro7 mpro7 deleted the add-stack-up-wo-app-target branch December 7, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants