Skip to content

feat: expose GET /admin/projects/[shortname | shortcode]/{shortname | shortcode} as ZIO HTTP routes (DEV-1587) - #2365

Merged
irinaschubert merged 8 commits into
mainfrom
wip/dev-1587-expose-admin-project-routes
Jan 4, 2023
Merged

irinaschubert merged 8 commits into
mainfrom
wip/dev-1587-expose-admin-project-routes

Conversation

@irinaschubert

@irinaschubert irinaschubert commented Jan 3, 2023 •

Copy link
Copy Markdown

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1587

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@swarmia

swarmia Bot commented Jan 3, 2023

Copy link
Copy Markdown

@irinaschubert irinaschubert self-assigned this Jan 3, 2023
@codecov

codecov Bot commented Jan 3, 2023 •

Copy link
Copy Markdown

Codecov Report

Base: 86.68% // Head: 86.49% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (422a960) compared to base (26e9596).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
- Coverage   86.68%   86.49%   -0.20%     
==========================================
  Files         250      271      +21     
  Lines       28252    28306      +54     
==========================================
- Hits        24490    24482       -8     
- Misses       3762     3824      +62     
Impacted Files Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.93% <100.00%> (+0.12%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 90.27% <100.00%> (+0.27%) ⬆️
.../scala/org/knora/webapi/responders/Responder.scala 75.00% <0.00%> (-16.43%) ⬇️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 88.27% <0.00%> (-5.79%) ⬇️
...n/scala/org/knora/webapi/routing/HealthRoute.scala 65.30% <0.00%> (-4.51%) ⬇️
.../webapi/messages/util/rdf/jenaimpl/JenaModel.scala 86.42% <0.00%> (-2.86%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 64.93% <0.00%> (-1.74%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 88.72% <0.00%> (-0.80%) ⬇️
...knora/webapi/responders/v1/ValuesResponderV1.scala 92.73% <0.00%> (-0.01%) ⬇️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 93.43% <0.00%> (-0.01%) ⬇️
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irinaschubert irinaschubert changed the title feat: Expose GET /admin/projects/[shortname | shortcode]/{shortname | shortcode} as ZIO HTTP routes feat: expose GET /admin/projects/[shortname | shortcode]/{shortname | shortcode} as ZIO HTTP routes Jan 4, 2023
@irinaschubert
irinaschubert marked this pull request as ready for review January 4, 2023 09:41

@BalduinLandolt BalduinLandolt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment thread webapi/src/test/scala/org/knora/webapi/routing/admin/ProjectsRouteZSpec.scala Outdated
Comment thread webapi/src/test/scala/org/knora/webapi/routing/admin/ProjectsRouteZSpec.scala Outdated
@irinaschubert
irinaschubert merged commit 9907cdf into main Jan 4, 2023
@irinaschubert
irinaschubert deleted the wip/dev-1587-expose-admin-project-routes branch January 4, 2023 11:07
@irinaschubert irinaschubert changed the title feat: expose GET /admin/projects/[shortname | shortcode]/{shortname | shortcode} as ZIO HTTP routes feat: expose GET /admin/projects/[shortname | shortcode]/{shortname | shortcode} as ZIO HTTP routes (DEV-1587) Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants