New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new upload route to Sipi without processing (DEV-1700) #2457
feat: Add new upload route to Sipi without processing (DEV-1700) #2457
Conversation
DEV-1700 Add new upload route to SIPI
Add another upload route to SIPI:
TODO
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2457 +/- ##
==========================================
- Coverage 86.67% 86.63% -0.04%
==========================================
Files 287 287
Lines 29669 29896 +227
==========================================
+ Hits 25716 25901 +185
- Misses 3953 3995 +42
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure though if I follow everything that happens in the lua script.
One thing you may consider is adding more log statements there, as we found it's very hard to see what's happening in SIPI. But if you think this suffices, then I'm absolutely happy with it. (Also, you could use the log util that adds the date and time in front of the log statements, but again, doesn't really matter that much.)
...a/org/knora/webapi/messages/v2/routing/authenticationmessages/AuthenticationMessagesV2.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 👍
Pull Request Checklist
Task Description/Number
Issue Number: DEV-1700
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?