Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new upload route to Sipi without processing (DEV-1700) #2457

Merged
merged 18 commits into from Mar 8, 2023

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Feb 17, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1700

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@linear
Copy link

linear bot commented Feb 17, 2023

DEV-1700 Add new upload route to SIPI

Add another upload route to SIPI:

  • upload files without processing (store files in Sipi's tmp folder)
  • return checksum and filename

TODO

@irinaschubert irinaschubert self-assigned this Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Patch coverage: 84.33% and project coverage change: -0.04 ⚠️

Comparison is base (e2dcd43) 86.67% compared to head (97a539b) 86.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
- Coverage   86.67%   86.63%   -0.04%     
==========================================
  Files         287      287              
  Lines       29669    29896     +227     
==========================================
+ Hits        25716    25901     +185     
- Misses       3953     3995      +42     
Impacted Files Coverage Δ
...main/scala/org/knora/webapi/core/HttpServerZ.scala 0.00% <0.00%> (ø)
...la/org/knora/webapi/core/actors/RoutingActor.scala 94.73% <ø> (-1.42%) ⬇️
...api/messages/store/sipimessages/SipiMessages.scala 100.00% <ø> (ø)
...tore/triplestoremessages/TriplestoreMessages.scala 80.30% <ø> (-0.76%) ⬇️
...esponder/standoffmessages/StandoffMessagesV1.scala 75.00% <ø> (ø)
...s/v1/responder/valuemessages/ValueMessagesV1.scala 69.39% <ø> (ø)
...henticationmessages/AuthenticationMessagesV2.scala 100.00% <ø> (ø)
...rg/knora/webapi/responders/v2/ontology/Cache.scala 98.38% <ø> (ø)
...ebapi/responders/v2/ontology/OntologyHelpers.scala 90.54% <ø> (-1.18%) ⬇️
...slice/resourceinfo/repo/ResourceInfoRepoLive.scala 0.00% <ø> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irinaschubert irinaschubert marked this pull request as ready for review March 6, 2023 16:33
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure though if I follow everything that happens in the lua script.

One thing you may consider is adding more log statements there, as we found it's very hard to see what's happening in SIPI. But if you think this suffices, then I'm absolutely happy with it. (Also, you could use the log util that adds the date and time in front of the log statements, but again, doesn't really matter that much.)

Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

sipi/config/sipi.docker-config.lua Outdated Show resolved Hide resolved
@irinaschubert irinaschubert merged commit 3cacc76 into main Mar 8, 2023
11 checks passed
@irinaschubert irinaschubert deleted the feature/dev-1700-add-new-upload-route-to-sipi branch March 8, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants