Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing github-actions workflow #2463

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Feb 21, 2023

Pull Request Checklist

Task Description/Number

With this change it should be possible again, to make the integration test workflow required.

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@BalduinLandolt BalduinLandolt self-assigned this Feb 21, 2023
@BalduinLandolt BalduinLandolt changed the title add missing workflow chore: add missing github-actions workflow Feb 21, 2023
@BalduinLandolt BalduinLandolt marked this pull request as ready for review February 21, 2023 10:51
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 9.70% // Head: 86.51% // Increases project coverage by +76.80% 🎉

Coverage data is based on head (93e47b9) compared to base (9884539).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #2463       +/-   ##
==========================================
+ Coverage   9.70%   86.51%   +76.80%     
==========================================
  Files        287      287               
  Lines      29482    29482               
==========================================
+ Hits        2862    25506    +22644     
+ Misses     26620     3976    -22644     
Impacted Files Coverage Δ
...g/knora/webapi/responders/v1/CkanResponderV1.scala 0.65% <0.00%> (+0.65%) ⬆️
...hared/src/main/scala/dsp/valueobjects/Schema.scala 99.04% <0.00%> (+0.95%) ⬆️
.../org/knora/webapi/messages/OntologyConstants.scala 99.62% <0.00%> (+1.26%) ⬆️
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.13% <0.00%> (+1.96%) ⬆️
...ared/src/main/scala/dsp/valueobjects/Project.scala 100.00% <0.00%> (+2.70%) ⬆️
...la/org/knora/webapi/routing/v1/AssetsRouteV1.scala 4.76% <0.00%> (+4.76%) ⬆️
...rc/main/scala/org/knora/webapi/RdfMediaTypes.scala 97.29% <0.00%> (+8.10%) ⬆️
...knora/webapi/routing/v1/ResourceTypesRouteV1.scala 8.21% <0.00%> (+8.21%) ⬆️
...cala/org/knora/webapi/routing/v1/CkanRouteV1.scala 9.09% <0.00%> (+9.09%) ⬆️
...knora/webapi/store/triplestore/errors/Errors.scala 12.50% <0.00%> (+12.50%) ⬆️
... and 201 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BalduinLandolt BalduinLandolt added this pull request to the merge queue Feb 22, 2023
Merged via the queue into main with commit 8983c95 Feb 22, 2023
@BalduinLandolt BalduinLandolt deleted the wip/add-missing-github-actions-test branch February 22, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants