refactor: rework removing of type annotations (DEV-2079) #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
===========================================
- Coverage 87.07% 14.16% -72.91%
===========================================
Files 267 271 +4
Lines 28686 28854 +168
===========================================
- Hits 24979 4088 -20891
- Misses 3707 24766 +21059
... and 169 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
BalduinLandolt
force-pushed
the
wip/DEV-2078-remove-more-intermediate-interfaces
branch
from
fcd11b2
to
f6471f9
Compare
Base automatically changed from
wip/DEV-2078-remove-more-intermediate-interfaces
to
main
April 21, 2023 13:58
BalduinLandolt
force-pushed
the
wip/DEV-2079-refactor-removing-type-annotations
branch
from
fc86152
to
b739cbe
Compare
BalduinLandolt
changed the base branch from
main
to
wip/move-query-transformers
mpro7
approved these changes
Apr 24, 2023
| } yield whereClause.copy(patterns = wherePatterns) | ||
| def removeTypeAnnotations(whereClause: WhereClause): Task[WhereClause] = { | ||
| val patterns = whereClause.patterns.flatMap(transformPattern) | ||
| ZIO.succeed(whereClause.copy(patterns = patterns)) |
There was a problem hiding this comment.
Suggested change
| ZIO.succeed(whereClause.copy(patterns = patterns)) | |
| ZIO.succeed(whereClause.copy(patterns)) |
There was a problem hiding this comment.
doesn't seem to work for copy() on a case class, without named param
BalduinLandolt
deleted the
wip/DEV-2079-refactor-removing-type-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-2079
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?