Small improvements in consistency checking and TransformData #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 14, 2016 16:45
…sformData. - Add a cardinality requiring an rdfs:label on every knora-base:Resource. - Improve error-handling if an rdfs:label is missing in a search result. - Add a consistency rule that forbids empty strings as objects. - Fix the Dokubib ontology so it's consistent with exported test data.
- Make error handling consistent in search responder.
|
Shouldn't there be a check in the InputValidation in Otherwise when using Knora with fuseki we would end up with empty strings whereas when using graphdb a consistency rule would be violated. And then you would want to load the data dumped from fuseki into graphdb and it does not work. |
|
OK, how's this? |
|
It is beautiful! Please add an E2E test for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformDatato add missingknora-base:isDeletedstatements.rdfs:labelon everyknora-base:Resource.rdfs:labelis missing in a search result.