Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve lucene handling in gravsearch (DEV-2148) #2667

Merged

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented May 15, 2023

Pull Request Checklist

Task Description/Number

Currently, LuceneQueryPattern is the only type in the Gravsearch AST which doesn't correspond to valid SPARQL, and it always gets transformed away into the same statement.
This PR removes the unnecessary type from the AST system.

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@linear
Copy link

linear bot commented May 15, 2023

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 94.23% and project coverage change: +2.16 🎉

Comparison is base (7af1c27) 85.13% compared to head (d9ee5c2) 87.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2667      +/-   ##
==========================================
+ Coverage   85.13%   87.30%   +2.16%     
==========================================
  Files         277      277              
  Lines       28958    28928      -30     
==========================================
+ Hits        24654    25256     +602     
+ Misses       4304     3672     -632     
Impacted Files Coverage Δ
...a/webapi/messages/util/search/QueryTraverser.scala 92.20% <ø> (-0.10%) ⬇️
...nora/webapi/messages/util/search/SparqlQuery.scala 83.01% <ø> (+0.77%) ⬆️
...h/gravsearch/transformers/OntologyInferencer.scala 92.50% <ø> (-1.25%) ⬇️
...ch/gravsearch/transformers/SelectTransformer.scala 83.33% <ø> (-2.39%) ⬇️
...rch/gravsearch/transformers/WhereTransformer.scala 100.00% <ø> (ø)
...a/org/knora/webapi/util/ZScopedJavaIoStreams.scala 86.36% <ø> (+38.21%) ⬆️
...ravsearch/types/GravsearchTypeInspectionUtil.scala 93.97% <83.33%> (+1.11%) ⬆️
...search/prequery/InferenceOptimizationService.scala 90.62% <87.50%> (+2.74%) ⬆️
...la/org/knora/webapi/routing/v2/SearchRouteV2.scala 85.15% <91.66%> (+0.23%) ⬆️
.../org/knora/webapi/messages/OntologyConstants.scala 99.74% <100.00%> (+0.12%) ⬆️
... and 5 more

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review May 15, 2023 20:56
@BalduinLandolt BalduinLandolt self-assigned this May 16, 2023
@BalduinLandolt BalduinLandolt enabled auto-merge (squash) May 17, 2023 11:41
@BalduinLandolt BalduinLandolt merged commit bf5d4be into main May 17, 2023
13 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/dev-2148-improve-lucene-handling-in-gravsearch branch May 17, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants