Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add sipi auth tests for knora.json (NO-Ticket) #2711

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Jun 19, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this Jun 19, 2023
@seakayone seakayone changed the title Add sipi auth tests (NO-Ticket) test: Add sipi auth tests for knora.json (NO-Ticket) Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 61.92% and project coverage change: +64.48 🎉

Comparison is base (ee3cddc) 17.89% compared to head (54dc82b) 82.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2711       +/-   ##
===========================================
+ Coverage   17.89%   82.38%   +64.48%     
===========================================
  Files         277      279        +2     
  Lines       28855    28936       +81     
===========================================
+ Hits         5165    23838    +18673     
+ Misses      23690     5098    -18592     
Impacted Files Coverage Δ
...esponder/standoffmessages/StandoffMessagesV2.scala 54.16% <0.00%> (+44.51%) ⬆️
...knora/webapi/responders/v1/ValuesResponderV1.scala 91.09% <ø> (+89.96%) ⬆️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 88.26% <ø> (+86.99%) ⬆️
...knora/webapi/responders/v2/SearchResponderV2.scala 91.81% <ø> (+85.40%) ⬆️
...ora/webapi/responders/v2/StandoffResponderV2.scala 86.21% <ø> (+82.97%) ⬆️
.../slice/admin/api/model/ProjectExportResponse.scala 0.00% <0.00%> (ø)
...slice/admin/domain/service/ProjectADMService.scala 96.77% <0.00%> (-3.23%) ⬇️
...a/webapi/store/iiif/impl/IIIFServiceSipiImpl.scala 50.74% <ø> (+50.00%) ⬆️
...ice/admin/api/service/ProjectsADMRestService.scala 60.00% <7.69%> (-17.78%) ⬇️
...rg/knora/webapi/routing/admin/ProjectsRouteZ.scala 90.65% <14.28%> (-4.50%) ⬇️
... and 21 more

... and 172 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone marked this pull request as ready for review June 19, 2023 13:14
@seakayone seakayone enabled auto-merge (squash) June 20, 2023 07:31
Comment on lines +47 to +49
suite("Endpoint /{prefix}/{identifier}/knora.json")(
suite("Given the user is unauthorized")(
suite("And given a .info file exists in Sipi")(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wonder if this test description could/should be in one suite, since there is only on test here?

@seakayone seakayone merged commit 85a30a5 into main Jun 20, 2023
13 checks passed
@seakayone seakayone deleted the add-sipi-auth-tests branch June 20, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants