refactor(TriplestoreServiceLive): minor improvements #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalduinLandolt
approved these changes
Jun 29, 2023
webapi/src/main/scala/org/knora/webapi/store/triplestore/impl/TriplestoreServiceLive.scala
Outdated
Show resolved
Hide resolved
| } yield DropDataGraphByGraphACK() | ||
|
|
||
| private def dropGraph(graphName: String): Task[Unit] = | ||
| ZIO.logInfo(s"Dropping graph: $graphName") *> | ||
| ZIO.logInfo(s"==>> Dropping graph: $graphName") *> |
There was a problem hiding this comment.
Suggested change
| ZIO.logInfo(s"==>> Dropping graph: $graphName") *> | |
| ZIO.logInfo(s" ==>> Dropping graph: $graphName") *> |
this will look nice with indention ^^
seakayone
approved these changes
Jun 29, 2023
webapi/src/main/scala/org/knora/webapi/store/triplestore/impl/TriplestoreServiceLive.scala
Outdated
Show resolved
Hide resolved
mpro7
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
==========================================
+ Coverage 9.55% 80.20% +70.65%
==========================================
Files 279 279
Lines 28936 28893 -43
==========================================
+ Hits 2766 23175 +20409
+ Misses 26170 5718 -20452
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Minor logging improvements and extracting duplicated code to private method.
Issue Number: NO-TICKET
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?