Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove type annotations which produce compiler warnings #2829

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Sep 8, 2023

Removed compiler warning:
pattern var ... in value $anonfun is never used: use a wildcard _ or suppress this warning with ...@_

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone requested review from mpro7 and BalduinLandolt and removed request for mpro7 September 8, 2023 07:44
@seakayone seakayone marked this pull request as ready for review September 8, 2023 07:44
Removed compiler warning:
pattern var ... in value $anonfun is never used: use a wildcard `_` or suppress this warning with `...@_`
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +70.00% 🎉

Comparison is base (12402f3) 18.00% compared to head (0de0546) 88.00%.
Report is 55 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2829       +/-   ##
===========================================
+ Coverage   18.00%   88.00%   +70.00%     
===========================================
  Files         281      242       -39     
  Lines       28899    23125     -5774     
===========================================
+ Hits         5202    20352    +15150     
+ Misses      23697     2773    -20924     

see 224 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seakayone seakayone self-assigned this Sep 8, 2023
@seakayone seakayone merged commit c754042 into main Sep 8, 2023
13 checks passed
@seakayone seakayone deleted the chore/remove-unused-2 branch September 8, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants