Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Akka with Pekko #2848

Merged
merged 11 commits into from Sep 28, 2023
Merged

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Sep 15, 2023

Apache Pekko is a fork of Akka 2.6.x, prior to the Akka project’s adoption of the Business Source License. Version 1.0.0 is a direct replacement of Akka 2.6.x and has support for Scala 3 already. https://pekko.apache.org/

See also the RFC for the proposed switch: https://www.notion.so/review-RFC-006-Replace-Akka-with-Pekko-12c2199a8bff43adb4d907073d33e878?pvs=4

Pull Request Checklist

Task Description/Number

Issue Number: DEV-2709

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone force-pushed the refactor/replace-akka-with-pekko branch from 71f76fa to 00b220d Compare September 15, 2023 12:39
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12402f3) 18.00% compared to head (39eb3e4) 88.04%.
Report is 70 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2848       +/-   ##
===========================================
+ Coverage   18.00%   88.04%   +70.04%     
===========================================
  Files         281      243       -38     
  Lines       28899    23089     -5810     
===========================================
+ Hits         5202    20329    +15127     
+ Misses      23697     2760    -20937     

see 228 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Apache Pekko is a fork of Akka 2.6.x, prior to the Akka project’s adoption of the Business Source License.
Version 1.0.0 is a direct replacement of Akka 2.6.x and has support for Scala 3 already.
https://pekko.apache.org/
@seakayone seakayone force-pushed the refactor/replace-akka-with-pekko branch from 00b220d to 018719e Compare September 19, 2023 09:15
@seakayone seakayone marked this pull request as ready for review September 19, 2023 10:52
@seakayone seakayone requested review from BalduinLandolt, mpro7 and subotic and removed request for BalduinLandolt and mpro7 September 19, 2023 13:49
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in the RFC: I'm happy to see this merged.

All my remarks are details concerning imports. Feel free to ignore them.

@seakayone seakayone merged commit d343d8e into main Sep 28, 2023
15 checks passed
@seakayone seakayone deleted the refactor/replace-akka-with-pekko branch September 28, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants