refactor: Remove redundancies in search by label queries #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2933 +/- ##
===========================================
+ Coverage 11.64% 88.50% +76.85%
===========================================
Files 246 247 +1
Lines 22885 22878 -7
===========================================
+ Hits 2666 20249 +17583
+ Misses 20219 2629 -17590 ☔ View full report in Codecov by Sentry. |
BalduinLandolt
changed the title
seakayone
approved these changes
Nov 16, 2023
| import org.knora.webapi.store.triplestore.api.TriplestoreService.Queries.Construct | ||
| import org.knora.webapi.store.triplestore.api.TriplestoreService.Queries.Select | ||
|
|
||
| object SearchUtil { |
There was a problem hiding this comment.
How about renaming this to SearchQueries which would reveal the intention of this "util" more.
There was a problem hiding this comment.
you're right, changed it accordingly
BalduinLandolt
deleted the
feature/dev-2061-refactor-queries-used-for-search-by-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?