-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make Sipi handling optional during FileValue creation (Dev-2945) #2960
Merged
BalduinLandolt
merged 39 commits into
main
from
dev-2945-dsp-api-during-filevalue-creation-make-sipi-handling
Dec 19, 2023
Merged
feat: Make Sipi handling optional during FileValue creation (Dev-2945) #2960
BalduinLandolt
merged 39 commits into
main
from
dev-2945-dsp-api-during-filevalue-creation-make-sipi-handling
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2960 +/- ##
==========================================
+ Coverage 11.62% 11.74% +0.12%
==========================================
Files 246 246
Lines 22870 22907 +37
==========================================
+ Hits 2658 2690 +32
- Misses 20212 20217 +5 ☔ View full report in Codecov by Sentry. |
mpro7
force-pushed
the
dev-2945-dsp-api-during-filevalue-creation-make-sipi-handling
branch
from
December 12, 2023 08:36
3500f35
to
303c47b
Compare
mpro7
changed the title
Dev 2945 dsp api during filevalue creation make sipi handling
make Sipi handling optional during FileValue creation (Dev-2945)
Dec 12, 2023
mpro7
changed the title
make Sipi handling optional during FileValue creation (Dev-2945)
Make Sipi handling optional during FileValue creation (Dev-2945)
Dec 12, 2023
mpro7
changed the title
Make Sipi handling optional during FileValue creation (Dev-2945)
feat: Make Sipi handling optional during FileValue creation (Dev-2945)
Dec 12, 2023
mpro7
force-pushed
the
dev-2945-dsp-api-during-filevalue-creation-make-sipi-handling
branch
from
December 13, 2023 09:35
4804129
to
d46cdb3
Compare
This reverts commit a8f7a46.
…ake-sipi-handling
seakayone
approved these changes
Dec 18, 2023
...pi/src/main/scala/org/knora/webapi/messages/v2/responder/valuemessages/ValueMessagesV2.scala
Outdated
Show resolved
Hide resolved
...pi/src/main/scala/org/knora/webapi/messages/v2/responder/valuemessages/ValueMessagesV2.scala
Outdated
Show resolved
Hide resolved
...pi/src/main/scala/org/knora/webapi/messages/v2/responder/valuemessages/ValueMessagesV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/store/iiif/impl/SipiServiceLive.scala
Outdated
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/messages/v2/responder/valuemessages/ValuesV2Spec.scala
Outdated
Show resolved
Hide resolved
BalduinLandolt
deleted the
dev-2945-dsp-api-during-filevalue-creation-make-sipi-handling
branch
December 19, 2023 17:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?