Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make Sipi handling optional during FileValue creation (Dev-2945) #2960

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Dec 8, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Dec 8, 2023

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (95ad2f9) 11.62% compared to head (b15cc26) 11.74%.
Report is 1 commits behind head on main.

Files Patch % Lines
...s/v2/responder/valuemessages/ValueMessagesV2.scala 12.28% 50 Missing ⚠️
...knora/webapi/store/iiif/impl/SipiServiceLive.scala 0.00% 9 Missing ⚠️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 0.00% 8 Missing ⚠️
...esponder/resourcemessages/ResourceMessagesV2.scala 0.00% 4 Missing ⚠️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 0.00% 4 Missing ⚠️
...la/org/knora/webapi/routing/v2/ValuesRouteV2.scala 0.00% 1 Missing ⚠️
...i/slice/admin/domain/service/DspIngestClient.scala 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2960      +/-   ##
==========================================
+ Coverage   11.62%   11.74%   +0.12%     
==========================================
  Files         246      246              
  Lines       22870    22907      +37     
==========================================
+ Hits         2658     2690      +32     
- Misses      20212    20217       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 self-assigned this Dec 8, 2023
@mpro7 mpro7 force-pushed the dev-2945-dsp-api-during-filevalue-creation-make-sipi-handling branch from 3500f35 to 303c47b Compare December 12, 2023 08:36
@mpro7 mpro7 changed the title Dev 2945 dsp api during filevalue creation make sipi handling make Sipi handling optional during FileValue creation (Dev-2945) Dec 12, 2023
@mpro7 mpro7 changed the title make Sipi handling optional during FileValue creation (Dev-2945) Make Sipi handling optional during FileValue creation (Dev-2945) Dec 12, 2023
@mpro7 mpro7 changed the title Make Sipi handling optional during FileValue creation (Dev-2945) feat: Make Sipi handling optional during FileValue creation (Dev-2945) Dec 12, 2023
@mpro7 mpro7 force-pushed the dev-2945-dsp-api-during-filevalue-creation-make-sipi-handling branch from 4804129 to d46cdb3 Compare December 13, 2023 09:35
@mpro7 mpro7 marked this pull request as ready for review December 13, 2023 12:03
@BalduinLandolt BalduinLandolt marked this pull request as draft December 13, 2023 16:07
@BalduinLandolt BalduinLandolt marked this pull request as ready for review December 18, 2023 12:49
@BalduinLandolt BalduinLandolt enabled auto-merge (squash) December 19, 2023 14:53
@BalduinLandolt BalduinLandolt merged commit 82ebce4 into main Dec 19, 2023
13 of 14 checks passed
@BalduinLandolt BalduinLandolt deleted the dev-2945-dsp-api-during-filevalue-creation-make-sipi-handling branch December 19, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants