Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename staging servers to stage in Makefile #2961

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

seakayone
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (44e6bdc) 11.63% compared to head (1158a36) 88.52%.
Report is 10 commits behind head on main.

Files Patch % Lines
...knora/webapi/messages/util/rdf/RdfFormatUtil.scala 84.41% 12 Missing ⚠️
...c/main/scala/org/knora/webapi/OntologySchema.scala 58.33% 10 Missing ⚠️
...cala/org/knora/webapi/slice/common/api/ApiV2.scala 82.60% 8 Missing ⚠️
...nora/webapi/slice/search/api/SearchEndpoints.scala 89.33% 8 Missing ⚠️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 70.58% 5 Missing ⚠️
.../knora/webapi/slice/common/api/BaseEndpoints.scala 70.58% 5 Missing ⚠️
...org/knora/webapi/messages/util/rdf/JenaModel.scala 87.50% 3 Missing ⚠️
...knora/webapi/responders/v2/SearchResponderV2.scala 93.87% 3 Missing ⚠️
.../store/triplestore/upgrade/RepositoryUpdater.scala 0.00% 3 Missing ⚠️
webapi/src/main/scala/dsp/valueobjects/Iri.scala 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2961       +/-   ##
===========================================
+ Coverage   11.63%   88.52%   +76.89%     
===========================================
  Files         246      246               
  Lines       22880    22870       -10     
===========================================
+ Hits         2661    20245    +17584     
+ Misses      20219     2625    -17594     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review December 11, 2023 09:11
@seakayone seakayone enabled auto-merge (squash) December 11, 2023 09:27
@seakayone seakayone merged commit bad8bbe into main Dec 11, 2023
15 checks passed
@seakayone seakayone deleted the feat/rename-staging branch December 11, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants