Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use the same custom scalac option for webapi and integration #2990

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Jan 10, 2024

…rojects

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (31a9260) 11.60%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
- Coverage   11.74%   11.60%   -0.14%     
==========================================
  Files         246      255       +9     
  Lines       22907    22989      +82     
==========================================
- Hits         2690     2669      -21     
- Misses      20217    20320     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone changed the title chore: use the same custom scalac option for webapi and integration chore: Use the same custom scalac option for webapi and integration Jan 10, 2024
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this give us now more warnings in the integration project? previously we didn't check for as many things there as we did in the webapi project

@seakayone
Copy link
Collaborator Author

does this give us now more warnings in the integration project? previously we didn't check for as many things there as we did in the webapi project

Yes.

@seakayone seakayone marked this pull request as ready for review January 10, 2024 14:57
@seakayone seakayone requested a review from mpro7 January 10, 2024 14:57
@seakayone seakayone merged commit b8a45ad into main Jan 10, 2024
12 of 15 checks passed
@seakayone seakayone deleted the chore/align-scalacOptions branch January 10, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants