refactor: Migrate GET /admin/lists?projectIri route to tapir
#3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3006 +/- ##
==========================================
- Coverage 11.74% 11.25% -0.49%
==========================================
Files 246 262 +16
Lines 22907 23091 +184
==========================================
- Hits 2690 2600 -90
- Misses 20217 20491 +274 ☔ View full report in Codecov by Sentry. |
* Renames: ** `ListsResponderADM` -> `ListsResponder` ** `SecuredEndpointAndZioHandler` -> `SecuredEndpointHandler` ** `EndpointAndZioHandler` -> `PublicEndpointHandler` * Removes `PublicEndpointHandler` generic type for `SECURITY_INPUT`, this is always `Unit` * Use PredicateObjectMapper and inline query as string
seakayone
force-pushed
the
refactor/migrate-admin-lists-route-to-tapir
branch
from
b9648af
to
23bb3f6
Compare
mpro7
approved these changes
Jan 29, 2024
...rc/main/scala/org/knora/webapi/messages/admin/responder/listsmessages/ListsMessagesADM.scala
Outdated
Show resolved
Hide resolved
seakayone
changed the title
GET /admin/lists?projectIri route to tapir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Migrates
GET /admin/listsandGET /admin/lists?projectIrito tapir.**
ListsResponderADM->ListsResponder**
SecuredEndpointAndZioHandler->SecuredEndpointHandler**
EndpointAndZioHandler->PublicEndpointHandlerPublicEndpointHandlergeneric type forSECURITY_INPUT, this is alwaysUnitPR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?