Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate GET /admin/users/iri/<userIri> to tapir #3010

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

seakayone
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Jan 29, 2024
@seakayone seakayone requested review from BalduinLandolt and mpro7 and removed request for BalduinLandolt January 29, 2024 10:40
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (50f9172) 88.53%.
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3010       +/-   ##
===========================================
+ Coverage   11.74%   88.53%   +76.79%     
===========================================
  Files         246      262       +16     
  Lines       22907    23090      +183     
===========================================
+ Hits         2690    20443    +17753     
+ Misses      20217     2647    -17570     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review January 29, 2024 10:47
@seakayone seakayone merged commit 34d2d7a into main Jan 29, 2024
13 checks passed
@seakayone seakayone deleted the refactor/migrate-get-user-by-iri-to-tapir branch January 29, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants