Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move code from UsersResponder to UserService and UserRestService #3067

Merged
merged 13 commits into from
Feb 28, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Feb 28, 2024

  • Replace UserResponder in Authenticator with UserService
  • Rename UserInformationTypeADM to UserInformationType
  • Move findByEmail and findByUsername to RestService
  • rm unused code
  • Move getProjectMemberShipsByUserIri to RestService
  • Move getProjectAdminMemberShipsByUserIri to RestService
  • Introduce ProjectADMService.findByIds(Seq[ProjectIri])
  • Extract getKnoraUserOrNotFound
  • fmt

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Feb 28, 2024

@seakayone seakayone self-assigned this Feb 28, 2024
@seakayone seakayone changed the title refactor: Move code from UsersResponder by UserService refactor: Move code from UsersResponder to UserService and UserRestService Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.55%. Comparing base (eac5751) to head (f874e71).
Report is 88 commits behind head on main.

Files Patch % Lines
...knora/webapi/responders/admin/UsersResponder.scala 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3067       +/-   ##
===========================================
+ Coverage   11.74%   88.55%   +76.81%     
===========================================
  Files         246      262       +16     
  Lines       22907    22513      -394     
===========================================
+ Hits         2690    19937    +17247     
+ Misses      20217     2576    -17641     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all I like it. Added one (non-blocking) question that left me a bit confused

@seakayone seakayone merged commit 5345350 into main Feb 28, 2024
13 checks passed
@seakayone seakayone deleted the refactor/remove-UsersResponder-DEV-3291-3 branch February 28, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants