-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move code from UsersResponder to UserService and UserRestService #3067
Conversation
…Full, Users.SystemUser) with ussing the UserService directly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
===========================================
+ Coverage 11.74% 88.55% +76.81%
===========================================
Files 246 262 +16
Lines 22907 22513 -394
===========================================
+ Hits 2690 19937 +17247
+ Misses 20217 2576 -17641 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over all I like it. Added one (non-blocking) question that left me a bit confused
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?