Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TransformData fix “test” labels on regions #311

Merged
merged 1 commit into from Nov 8, 2016

Conversation

benjamingeer
Copy link

Before SALSAH correctly supported labels, labels were hard-coded as test, and this affected regions created by the BEOL project. This pull request adds a regionlabels transformation to TransformData, which looks for regions whose rdfs:label is test, and replaces each one's label with the valueHasString of its hasComment.

@benjamingeer benjamingeer added the enhancement improve existing code or new feature label Nov 7, 2016
@benjamingeer benjamingeer added this to the Beta Release milestone Nov 7, 2016
@tobiasschweizer
Copy link
Contributor

Great, please merge!

@benjamingeer benjamingeer merged commit ee6401a into develop Nov 8, 2016
@benjamingeer benjamingeer deleted the wip/fix-test-labels branch November 8, 2016 12:00
SepidehAlassi added a commit that referenced this pull request Dec 13, 2016
* develop:
  Improve configuration for more concurrent requests (#338)
  Upgrade to Scala 2.12 (#343)
  Fix various inconsistencies in knora-base.ttl and docs. (#330)
  Fix language switching and login/logout in SALSAH (#331)
  Graph data API operation (#267)
  Allow connections over HTTPS (#332)
  Update README.md
  Add link to GraphDB.
  fix (salsah): Add missing JavaScript “var”.
  fix (webapi): Fix RouteUtilV1 so it returns HTML instead of JSON when requested (#326)
  Ontology and documentation fixes. (#325)
  fix (salsah): Create multiple links in a resource, and other bug fixes (#315)
  feature (webapi): Make TransformData fix “test” labels on regions. (#311)
  Fixes for subclasses and subproperties (#303)
  Add script to update docs on knora.org (#300)
  docs: Make trivial change for testing purposes.
  fix (webapi): CORS problems (#307)
  Use inference to optimise searches on GraphDB (#301)
@benjamingeer benjamingeer mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants