Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Merge StringLiteralV2 classes #3133

Merged
merged 9 commits into from
Mar 20, 2024
Merged

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Mar 19, 2024

Pull Request Checklist

Task Description/Number

This PR merges StringLiteralV2 classes (removes V2 object), that were at some point duplicated. I decided to keep the location of the old class, to make most probably make this merge possible.
Constructor is now private and the optional parameter check was moved to companion object, namely to the from method. This could be even more improved in the future.
Most of the line changes are related to importing and name change.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 28.94737% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 13.15%. Comparing base (eac5751) to head (ccfffc1).
Report is 142 commits behind head on main.

Files Patch % Lines
...la/org/knora/webapi/slice/admin/api/Examples.scala 0.00% 7 Missing ⚠️
...tore/triplestoremessages/TriplestoreMessages.scala 45.45% 6 Missing ⚠️
...cala/org/knora/webapi/slice/admin/api/Codecs.scala 0.00% 4 Missing ⚠️
...sponder/projectsmessages/ProjectsMessagesADM.scala 0.00% 2 Missing ⚠️
...esponder/ontologymessages/OntologyMessagesV2.scala 0.00% 2 Missing ⚠️
...la/org/knora/webapi/messages/StringFormatter.scala 0.00% 1 Missing ⚠️
...rg/knora/webapi/messages/util/rdf/JsonLDUtil.scala 0.00% 1 Missing ⚠️
...s/KnoraBaseToApiV2ComplexTransformationRules.scala 0.00% 1 Missing ⚠️
...es/KnoraBaseToApiV2SimpleTransformationRules.scala 0.00% 1 Missing ⚠️
...webapi/responders/admin/ProjectsResponderADM.scala 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
+ Coverage   11.74%   13.15%   +1.40%     
==========================================
  Files         246      264      +18     
  Lines       22907    22395     -512     
==========================================
+ Hits         2690     2945     +255     
+ Misses      20217    19450     -767     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 marked this pull request as ready for review March 19, 2024 16:01
@mpro7 mpro7 self-assigned this Mar 19, 2024
Copy link
Collaborator

@seakayone seakayone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: This was bugging me too, thanks for merging these.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@mpro7 mpro7 enabled auto-merge (squash) March 20, 2024 09:28
@mpro7 mpro7 merged commit 70cced2 into main Mar 20, 2024
13 checks passed
@mpro7 mpro7 deleted the refactor/stringliteralv2 branch March 20, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants