-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Introduce administrative permission service #3172
Merged
seakayone
merged 29 commits into
main
from
refactor/introduce-administrative-permission-service
Apr 9, 2024
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
1dfa7f4
refactor: Rename PermissionResponder and add AdministrativePermission…
seakayone 7f1d222
Integrate AdministrativePermissionService into PermissionsResponder a…
seakayone c97b28d
disable login for builtIn users
seakayone 81962ae
fmt
seakayone 665e1fb
refactor: make org.knora.webapi.responders.admin.PermissionsResponder…
seakayone fa414e7
simplify
seakayone 853d63c
rename getPermissionData
seakayone 023fd87
cleanup spec
seakayone 01a92a8
cleanup GroupService
seakayone 0c75589
header
seakayone bbe4779
Use ZIO.foreach (simplify)
seakayone f993963
Use ZIO.foreach (simplify)
seakayone c60b915
cleanup
seakayone f086ef2
remove unused tuple part
seakayone 2a12b16
simplify
seakayone 2ff0400
simplify
seakayone 58966b5
simplify
seakayone 53a26ac
simplify
seakayone 7619126
fmt
seakayone 73ff423
cleanup
seakayone e3714d9
add types
seakayone c717468
fmt
seakayone 3c79e8c
move code to KnoraUserToUserConverter
seakayone e90b109
improve type safety internally
seakayone c1a2d25
migrate KnoraUserToUserConverterSpec to zio-test E2EZSpec
seakayone 8f17f68
header
seakayone c23672f
cleanup
seakayone aeb6126
cleanup
seakayone 9085f84
align naming findByIds
seakayone File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: could we put those on one line each? Scalafmt doesn't do it automatically, but it doesn't undo it either, I think. And the diffs would be less nasty.