Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update apache-jena-fuseki to v5.0.0-1 #3176

Merged
merged 6 commits into from
Apr 10, 2024
Merged

chore: Update apache-jena-fuseki to v5.0.0-1 #3176

merged 6 commits into from
Apr 10, 2024

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Apr 8, 2024

Pull Request Checklist

Task Description/Number

During the update to the newest Docker container version (which already has Jena Fuseki v5.0.0) the only one test in TriplestoreServiceLiveZSpec failed. It was at the end removed, because it never was testing anything meaningful, but only error code to exception mapping. No matter what query was used, the result was always the same (including also the simplest query ?sub ?pred ?obj). Now instead of 404 which was mapped to NotFoundException, the 405 code was received - which is mapped to default TriplestoreResponseException, thus the test failed.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@mpro7 mpro7 marked this pull request as ready for review April 9, 2024 14:27
@mpro7 mpro7 self-assigned this Apr 9, 2024
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, the test probably never actually tested anything anyway

@mpro7 mpro7 merged commit 68de1c6 into main Apr 10, 2024
11 checks passed
@mpro7 mpro7 deleted the mpro7-patch-3 branch April 10, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants