New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reflection error when dump-messages=true in application.conf #428
Conversation
@loicjaouen Please let me know if this fixes your error. |
Wouldn't it make more sense to let Loïc review this pull request? |
I have already asked @loicjaouen for a review. ;-) |
Ah, now it seems correct. I had the impression that I was added in the reviewers section. |
You were, I just wanted to give you something to do in case you were bored. :) |
I am the root of boredom. No pull request could change that. |
I am not sure that I can reproduce it anymore...
but I don't see the |
I will check... |
@loicjaouen You need this in
and this in
Can you try that and let me know if it works for you? If so, don't forget to approve the changes in this PR so I can merge it (you're the reviewer). |
perfect, please merge :) |
You have to "Review changes" and "Approve changes" before I can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
i'm still learning |
No problem, thanks :) |
This was implemented in
RouteUtilV1
usingMessageUtil.toSource
, but I can't guarantee that that method can handle any message object, so this changesRouteUtilV1
to usetoString
instead.Fixes #427.