Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflection error when dump-messages=true in application.conf #428

Merged
merged 5 commits into from Mar 2, 2017

Conversation

benjamingeer
Copy link

This was implemented in RouteUtilV1 using MessageUtil.toSource, but I can't guarantee that that method can handle any message object, so this changes RouteUtilV1 to use toString instead.

Fixes #427.

@benjamingeer benjamingeer added the bug something isn't working label Feb 21, 2017
@benjamingeer benjamingeer added this to the Beta Release milestone Feb 21, 2017
@benjamingeer benjamingeer self-assigned this Feb 21, 2017
@benjamingeer
Copy link
Author

@loicjaouen Please let me know if this fixes your error.

@tobiasschweizer
Copy link
Contributor

Wouldn't it make more sense to let Loïc review this pull request?

@benjamingeer
Copy link
Author

I have already asked @loicjaouen for a review. ;-)

@tobiasschweizer
Copy link
Contributor

Ah, now it seems correct. I had the impression that I was added in the reviewers section.

@benjamingeer
Copy link
Author

I had the impression that I was added in the reviewers section.

You were, I just wanted to give you something to do in case you were bored. :)

@tobiasschweizer
Copy link
Contributor

I am the root of boredom. No pull request could change that.

@loicjaouen
Copy link
Collaborator

I am not sure that I can reproduce it anymore...
I set the config:

    loglevel = "DEBUG"
    stdout-loglevel = "DEBUG"
[...]
 dump-messages = true 

but I don't see the DEBUG logging in the console or the log file :(

@benjamingeer benjamingeer requested review from tobiasschweizer and removed request for tobiasschweizer March 1, 2017 18:57
@benjamingeer
Copy link
Author

I will check...

@benjamingeer
Copy link
Author

@loicjaouen You need this in application.xml:

loglevel = "DEBUG"

and this in logback.xml:

<root level="DEBUG">

Can you try that and let me know if it works for you? If so, don't forget to approve the changes in this PR so I can merge it (you're the reviewer).

@loicjaouen
Copy link
Collaborator

perfect, please merge :)

@benjamingeer
Copy link
Author

You have to "Review changes" and "Approve changes" before I can merge.

Copy link
Collaborator

@loicjaouen loicjaouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@loicjaouen
Copy link
Collaborator

i'm still learning

@benjamingeer
Copy link
Author

No problem, thanks :)

@benjamingeer benjamingeer merged commit 0b21a47 into develop Mar 2, 2017
@benjamingeer benjamingeer deleted the wip/dump-messages branch March 2, 2017 15:23
@benjamingeer benjamingeer mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants