Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): upload video (DEV-204) #577

Merged
merged 29 commits into from Apr 6, 2022
Merged

Conversation

kilchenmann
Copy link
Contributor

@kilchenmann kilchenmann commented Nov 5, 2021

resolves DEV-204

@kilchenmann kilchenmann self-assigned this Nov 5, 2021
@kilchenmann kilchenmann marked this pull request as draft Nov 5, 2021
@kilchenmann kilchenmann changed the title feat(resource): upload video feat(resource): upload video (DEV-204) Nov 12, 2021
@kilchenmann kilchenmann requested a review from mdelez Apr 5, 2022
@kilchenmann kilchenmann marked this pull request as ready for review Apr 5, 2022
@kilchenmann
Copy link
Contributor Author

kilchenmann commented Apr 5, 2022

@mdelez this should work now with the api from main branch (not yet released) and it is ready for review

mdelez
mdelez approved these changes Apr 6, 2022
// this.thumbnailUrl = res.uploadedFiles[0].temporaryUrl;
this.thumbnailUrl = undefined;
this.thumbnailUrl = res.uploadedFiles[0].temporaryUrl;
// this.thumbnailUrl = undefined;
Copy link
Collaborator

@mdelez mdelez Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can probably be removed

Copy link
Contributor Author

@kilchenmann kilchenmann Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 9bb22b9

@kilchenmann kilchenmann merged commit 29201d4 into main Apr 6, 2022
13 checks passed
@kilchenmann kilchenmann deleted the wip/dev-204-upload-video branch Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants