Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authentication): set active datadog rum user (DEV-325) #624

Merged
merged 12 commits into from
Dec 16, 2021
Merged

fix(authentication): set active datadog rum user (DEV-325) #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
92e4502
refactor(login): new login structure
kilchenmann Dec 14, 2021
62b9d1d
refactor(login): new login structure
kilchenmann Dec 15, 2021
370bcb9
refactor(login): new login structure
kilchenmann Dec 15, 2021
baf5f57
Merge branch 'main' into wip/dev-325-logout
kilchenmann Dec 15, 2021
51031dd
refactor(header): clean up code
kilchenmann Dec 15, 2021
5ffb5ad
refactor(tests): clean up tests
kilchenmann Dec 15, 2021
f926c03
refactor(login): new login structure
kilchenmann Dec 15, 2021
6c8118d
fix(datadog): re-init data dog user
kilchenmann Dec 15, 2021
e5126ad
test(session): fix tests
kilchenmann Dec 15, 2021
032b3cf
Merge branch 'main' into wip/dev-325-logout
kilchenmann Dec 15, 2021
1a99017
fix(authentication): set active datadog rum user
kilchenmann Dec 15, 2021
bc41e99
fix(authentication): set active datadog rum user
kilchenmann Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/main/services/authentication.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('AuthenticationService', () => {

const cacheServiceSpy = jasmine.createSpyObj('CacheService', ['destroy']);

const datadogRumServiceSpy = jasmine.createSpyObj('datadogRumService', ['removeActiveUser']);
const datadogRumServiceSpy = jasmine.createSpyObj('datadogRumService', ['', 'removeActiveUser']);


beforeEach(() => {
Expand Down
8 changes: 5 additions & 3 deletions src/app/main/services/datadog-rum.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,11 @@ export class DatadogRumService {
});

// if session is valid: setActiveUser
this._session.isSessionValid().subscribe((response) => {
const session: Session = this._session.getSession();
this.setActiveUser(session.user.name, 'username');
this._session.isSessionValid().subscribe((response: boolean) => {
if (response) {
const session: Session = this._session.getSession();
this.setActiveUser(session.user.name, 'username');
}
});

}
Expand Down