refactor: improve logging

dasch-swiss · Jun 7, 2023 · 895e3fa · 895e3fa
1 parent 728cf4b
commit 895e3fa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -53,9 +53,9 @@ docker-publish-app: app-build-prod ## publish DSP-APP Docker image to Docker-Hub
 	# publish source maps to DataDog
 	datadog-ci sourcemaps upload ${CURRENT_DIR}/dist/apps/dsp-app \
       --service=dsp-app \
-      --release-version=${BUILD_TAG} \
+      --release-version=${DSP_APP_VERSION} \
       --minified-path-prefix=/
-	docker buildx build --platform linux/amd64,linux/arm64/v8 -t $(DSP_APP_IMAGE) --push .
+	# docker buildx build --platform linux/amd64,linux/arm64/v8 -t $(DSP_APP_IMAGE) --push .
 
 .PHONY: docker-publish
 docker-publish: docker-publish-app ## publish all Docker images in the monorepo.

diff --git a/libs/vre/shared/app-logging/src/lib/app-logging/app-logging.service.ts b/libs/vre/shared/app-logging/src/lib/app-logging/app-logging.service.ts
@@ -21,6 +21,7 @@ export class AppLoggingService {
                 env: c.environment,
                 forwardErrorsToLogs: true, // forwards console.error logs, uncaught exceptions and network errors to Datadog
                 forwardConsoleLogs: [], // don't forward any logs (besides console.error - in previous setting) to Datadog
+                useSecureSessionCookie: true,
             });
             datadogLogs.logger.setHandler(['console', 'http']);
             this.logger = datadogLogs.logger;

diff --git a/vars.mk b/vars.mk
@@ -7,3 +7,7 @@ endif
 ifeq ($(DSP_APP_IMAGE),)
 	DSP_APP_IMAGE := $(DSP_APP_REPO):$(BUILD_TAG)
 endif
+
+ifeq ($(DSP_APP_VERSION),)
+	DSP_APP_VERSION := $(shell jq .version package.json)
+endif