Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): host listener triggers when user types in an input or textarea #1233

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Oct 18, 2023

resolves DEV-2844

@mdelez mdelez added the bug A bug fix label Oct 18, 2023
@mdelez mdelez self-assigned this Oct 18, 2023
@linear
Copy link

linear bot commented Oct 18, 2023

DEV-2844 Data browser host listener also triggers when user is typing in an input

Our super secret key binding of [ to show hide the sidenav in the data browser also triggers when the user types [ in an input field. The host listener should check if the event is coming from an input or textarea.

@mdelez mdelez requested a review from irmastnt October 18, 2023 10:46
@mdelez mdelez marked this pull request as ready for review October 18, 2023 10:46
@mdelez mdelez merged commit 9f2a790 into main Oct 18, 2023
13 checks passed
@mdelez mdelez deleted the feature/dev-2844-data-browser-host-listener-also-triggers-when-user-is-typing branch October 18, 2023 12:14
irmastnt added a commit that referenced this pull request Oct 30, 2023
…return-true-observables-that-also

* main:
  fix(advanced search link): Add route constant (#1238)
  feat: restore previous advanced search that user executed (#1226)
  refactor(routing): apply route constants (#1227)
  chore(main): release 10.24.2 (#1234)
  fix(date-picker): fix YYYY-MM-dd formatting (#1235)
  chore: Reconfigure all "zio" endpoints to use the original address (#1222)
  fix(project): host listener triggers when user types in an input or textarea (#1233)
  fix(gravsearch-service): incorrect gravsearch generated when searching for a linked property (#1232)
  chore(main): release 10.24.1 (#1225)
  fix(advanced-search): generate correct gravsearch for linked resources with property values (#1229)
  refactor(string literal component): move app string literal component into shared lib (#1209)
  chore(main): release 10.24.0 (#1218)
  chore: update dsp-js to v8.3.6 (#1224)
  feat: dev-2557-update-the-documentation-1 (#1221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants