refactor(routing): apply route constants #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelez
approved these changes
Oct 24, 2023
| @@ -78,27 +78,30 @@ export class OntologyClassInstanceComponent implements OnChanges { | |||
| this.session = this._sessionService.getSession(); | |||
|
|
|||
| this._route.params.subscribe((params) => { | |||
| console.log('params', params); | |||
irmastnt
approved these changes
Oct 24, 2023
| @@ -145,6 +145,10 @@ export class OntologyComponent implements OnInit { | |||
| // disable content on small devices | |||
| disableContent = false; | |||
|
|
|||
| // route to classes view | |||
| classesLink = `../${RouteConstants.classes}`; | |||
There was a problem hiding this comment.
instead of creating multiple variables, you can just pass routeConstants to the view:
routeConstants = RouteConstants;
irmastnt
added a commit
that referenced
this pull request
Oct 30, 2023
…return-true-observables-that-also * main: fix(advanced search link): Add route constant (#1238) feat: restore previous advanced search that user executed (#1226) refactor(routing): apply route constants (#1227) chore(main): release 10.24.2 (#1234) fix(date-picker): fix YYYY-MM-dd formatting (#1235) chore: Reconfigure all "zio" endpoints to use the original address (#1222) fix(project): host listener triggers when user types in an input or textarea (#1233) fix(gravsearch-service): incorrect gravsearch generated when searching for a linked property (#1232) chore(main): release 10.24.1 (#1225) fix(advanced-search): generate correct gravsearch for linked resources with property values (#1229) refactor(string literal component): move app string literal component into shared lib (#1209) chore(main): release 10.24.0 (#1218) chore: update dsp-js to v8.3.6 (#1224) feat: dev-2557-update-the-documentation-1 (#1221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.