chore(fulltext-search): filter out deactivated projects and system projects #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-1763 Deleted project should not be available in the full-text search filter list
Once a project has been deleted, it should no longer be visible in the dropdown menu of the full-text search bar (see attached screenshot). Only projects with the “status = true” should be shown in the dropdown list. true = active, not deleted |
Vijeinath
reviewed
Apr 19, 2023
| this.projects = response.body.projects; | ||
| // this.loadSystem = false; | ||
| // filter out deactivated projects and system projects | ||
| this.projects = response.body.projects.filter(p => p.status === true && !this.doNotDisplay.includes(p.id)); |
There was a problem hiding this comment.
Maybe replace the name "doNotDisplay" with "hideProjects" so there is not double negation
There was a problem hiding this comment.
makes sense, changed in bf146e0
mdelez
deleted the
feature/dev-1763-deleted-project-should-not-be-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1763