-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app-config): improve type-safety of parsed configuration #1074
Merged
subotic
merged 9 commits into
main
from
feature/dev-2228-make-app-config-parsing-config-json-type-safe
Jun 5, 2023
Merged
refactor(app-config): improve type-safety of parsed configuration #1074
subotic
merged 9 commits into
main
from
feature/dev-2228-make-app-config-parsing-config-json-type-safe
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subotic
requested review from
mdelez,
Vijeinath,
domsteinbach and
EricSommerhalder
June 2, 2023 16:21
Vijeinath
reviewed
Jun 5, 2023
Vijeinath
reviewed
Jun 5, 2023
Vijeinath
reviewed
Jun 5, 2023
Vijeinath
reviewed
Jun 5, 2023
libs/vre/shared/app-config/src/lib/app-config/app-config.service.spec.ts
Outdated
Show resolved
Hide resolved
Vijeinath
reviewed
Jun 5, 2023
libs/vre/shared/app-config/src/lib/app-config/app-config.service.spec.ts
Outdated
Show resolved
Hide resolved
Vijeinath
approved these changes
Jun 5, 2023
…fig-json-type-safe
…pe-safe' of github.com:dasch-swiss/dsp-das into feature/dev-2228-make-app-config-parsing-config-json-type-safe
subotic
deleted the
feature/dev-2228-make-app-config-parsing-config-json-type-safe
branch
June 5, 2023 11:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-2228