Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp-app): fixed wrong error-messages in update forms #1106

Merged

Conversation

EricSommerhalder
Copy link
Contributor

resolves DEV-1951

@linear
Copy link

linear bot commented Jun 19, 2023

DEV-1951 Wrong error message in form validation

In the ontology editor you can see that for the class Picture no property is required.

When you open the resource viewer and you edit the entry "OldTitle" of a resource, click in the field and beside again the error message appears that this field is a required field.

Screenshot 2023-03-23 at 06.31.45.png

Screenshot 2023-03-23 at 06.32.13.png

Sample resource : https://admin.test.dasch.swiss/resource/1111/9nz2Dew-Qsy7jevLgRbT8Q

Expected behavior:

In general no error message should be shown if a value is not required as well as no Asterisk symbol in the placeholder text

Copy link
Collaborator

@mdelez mdelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieht bueno to moi

@EricSommerhalder EricSommerhalder merged commit c9e5d3f into main Jun 20, 2023
11 checks passed
@EricSommerhalder EricSommerhalder deleted the feature/dev-1951-wrong-error-message-in-form-validation branch June 20, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants