Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow access to app locally on host 0.0.0.0 #1111

Merged

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Jun 22, 2023

resolves DEV-2307

@mdelez mdelez added the chore Maintenance and build tasks label Jun 22, 2023
@linear
Copy link

linear bot commented Jun 22, 2023

DEV-2307 Allow accessing DSP-APP locally on host 0.0.0.0

Something changed, I'm not sure what but we lost the ability to access the app via 0.0.0.0 when running the app locally. This means that anything relating to SIPI and authorization won't work. This is an easy enough fix. We just need to specify the host in the npm script.

@mdelez mdelez marked this pull request as ready for review June 22, 2023 13:46
@mdelez mdelez merged commit e193e78 into main Jun 23, 2023
11 checks passed
@mdelez mdelez deleted the feature/dev-2307-allow-accessing-dsp-app-locally-on-host-0000 branch June 23, 2023 07:38
@mdelez mdelez restored the feature/dev-2307-allow-accessing-dsp-app-locally-on-host-0000 branch June 23, 2023 09:56
@mdelez mdelez deleted the feature/dev-2307-allow-accessing-dsp-app-locally-on-host-0000 branch June 23, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance and build tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants