Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remove property menu): add skeleton to mat menu until content loaded #1148

Merged
merged 6 commits into from Jul 18, 2023
Merged

feat(remove property menu): add skeleton to mat menu until content loaded #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd6a4e9
style(mat-menu): increase max-width
domsteinbach Jul 17, 2023
0f757dc
feat(remove property menu): introduce skeleton-loader for mat-menu
domsteinbach Jul 17, 2023
d128db1
chore (lint): fix lint error
domsteinbach Jul 17, 2023
f73d653
Merge branch 'main' into wip/dev-1931-add-skeleton-to-mat-menu
domsteinbach Jul 17, 2023
6479ca0
Merge branch 'main' into wip/dev-1931-add-skeleton-to-mat-menu
domsteinbach Jul 18, 2023
53e02b3
Merge branch 'main' into wip/dev-1931-add-skeleton-to-mat-menu
domsteinbach Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 19 additions & 6 deletions ...ource-class-info/resource-class-property-info/resource-class-property-info.component.html
View file
Open in desktop
Expand Up @@ -18,12 +18,25 @@
<mat-icon [matMenuTriggerFor]="classInfoMenu" class="menu-icon-button" (click)="canBeRemovedFromClass()">more_vert</mat-icon>
</span>
<mat-menu #classInfoMenu="matMenu">
<button mat-menu-item
[disabled] = "!propCanBeRemovedFromClass"
(click)="removePropertyFromClass.emit({iri: propDef.id, label: propDef.label})">
<mat-icon>link_off</mat-icon>
<span>remove property from class</span>
</button>
<div class='remove-menu-wrapper'>
<button mat-menu-item
[disabled] = "!propCanBeRemovedFromClass"
(click)="removePropertyFromClass.emit({iri: propDef.id, label: propDef.label})">
<mat-icon>link_off</mat-icon>
<ngx-skeleton-loader
*ngIf="propCanBeRemovedFromClass === undefined || propCanBeRemovedFromClass === null"
count="1"
appearance="line"
class='skeleton'
[theme]="{
'margin-bottom': 0,
'vertical-align': 'middle',
'min-width' : '16em'
}">
</ngx-skeleton-loader>
<span *ngIf="propCanBeRemovedFromClass !== undefined">remove property from class</span>
</button>
</div>
</mat-menu>
</div>
</div>
Expand Down
5 changes: 5 additions & 0 deletions ...ource-class-info/resource-class-property-info/resource-class-property-info.component.scss
View file
Open in desktop
Expand Up @@ -64,3 +64,8 @@
font-size: medium;
cursor: pointer;
}

.remove-menu-wrapper {
min-width: 18em;
width: 18em;
}
1 change: 1 addition & 0 deletions apps/dsp-app/src/styles.scss
View file
Open in desktop
Expand Up @@ -185,6 +185,7 @@ button.space-reducer {

.mat-mdc-menu-panel {
min-height: 48px !important;
max-width: 400px !important;
}

.full-size-dialog {
Expand Down