Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text values): open all non internal links in a new tab #1167

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix(text values): open all non internal links in a new tab #1167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d27b93
fix(text values): Open all non internal links in a new tab
domsteinbach Jul 26, 2023
6c8aa3a
Merge branch 'main' into wip/dev-2476-external-links-open-in-the-same…
domsteinbach Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions apps/dsp-app/src/app/workspace/resource/directives/text-value-html-link.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,19 @@ export class TextValueHtmlLinkDirective {
*/
@HostListener('mousedown', ['$event.target'])
onClick(targetElement) {
if (targetElement.nodeName.toLowerCase() !== 'a') {
return false; // only handle click events on links
}
if (
targetElement.nodeName.toLowerCase() === 'a' &&
targetElement.className
.toLowerCase()
.indexOf(Constants.SalsahLink) !== -1
) {
this.internalLinkClicked.emit(targetElement.href);

// preventDefault (propagation)
return false;
} else {
// open all other links as external links in a new tab
window.open(targetElement.href, '_blank');
return false;
}
}
Expand Down