Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ontology form): remove the input decorator #1212

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix(ontology form): remove the input decorator #1212

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae86ea
fix(ontology form): remove the input decorator
domsteinbach Oct 3, 2023
e33420b
chore: change order of the class members
domsteinbach Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/dsp-app/src/app/main/dialog/dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@
<app-ontology-form
[projectUuid]="data.project"
(closeDialog)="dialogRef.close($event)"
[existingOntologyNames]="data.existing"
></app-ontology-form>
</div>

Expand All @@ -373,7 +372,6 @@
[iri]="data.id"
[projectUuid]="data.project"
(closeDialog)="dialogRef.close($event)"
[existingOntologyNames]="data.existing"
></app-ontology-form>
</div>

Expand Down
5 changes: 3 additions & 2 deletions apps/dsp-app/src/app/project/ontology/ontology-form/ontology-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class OntologyFormComponent implements OnInit {
@Input() iri: string;

// existing ontology names; name has to be unique
@Input() existingOntologyNames: string[] = [];
existingOntologyNames: string[] = [];

@Output() closeDialog: EventEmitter<any> = new EventEmitter<any>();

Expand Down Expand Up @@ -139,7 +139,8 @@ export class OntologyFormComponent implements OnInit {
this.projectUuid = this._route.parent.snapshot.params.uuid;
}

if (!this.existingOntologyNames.length) {
if (!this.iri && !this.existingOntologyNames.length) {
// if there is no iri, we are creating a new ontology
this._applicationStateService.get('currentProjectOntologies').subscribe(
(response: ReadOntology[]) => {
response.forEach((onto) => {
Expand Down