Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dsp-das): image settings (DEV-2995) #1440

Merged
merged 12 commits into from
Feb 8, 2024
Merged

feat(dsp-das): image settings (DEV-2995) #1440

merged 12 commits into from
Feb 8, 2024

Conversation

irmastnt
Copy link
Contributor

@irmastnt irmastnt commented Feb 7, 2024

resolves DEV-2995

@irmastnt
feat(dsp-das): image settings
1ce852e
@irmastnt
Merge branch 'main' into feature/dev-2995-add-form-to-update-restrict…
925bcfc 
…ed-view-settings-watermark-and

* main:
  chore(main): release 11.4.0 (#1432)
  fix: list node gets updated (#1437)
  fix: login works with specific api errors  (#1433)
  style: flex slider in parent element (#1429)
  chore: update eslint packages (#1430)
  feat: add openApi generated code (#1431)
@irmastnt
feat(dsp-das): image settings
96164c0
@linear Linear
Copy link

linear bot commented Feb 7, 2024

DEV-2995 Add form to update restricted view settings (watermark and size)

derschnee68
derschnee68 reviewed Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@derschnee68 derschnee68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This route does not work, while it did before
http://localhost:4200/project/00FF/edit

derschnee68
derschnee68 reviewed Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@derschnee68 derschnee68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Project settings button is missing between Project description and data-model buttons

libs/vre/shared/app-analytics/src/lib/grafana-faro.service.ts Outdated Show resolved Hide resolved
libs/vre/shared/app-api/src/lib/services/admin/project-api.service.ts Outdated Show resolved Hide resolved
libs/vre/shared/app-api/src/lib/services/admin/project-api.service.ts Outdated Show resolved Hide resolved
apps/dsp-app/src/app/project/image-settings/project-image-settings.ts Outdated Show resolved Hide resolved
@irmastnt irmastnt merged commit 3609b52 into main Feb 8, 2024
13 checks passed
@irmastnt irmastnt deleted the feature/dev-2995-add-form-to-update-restricted-view-settings-watermark-and branch February 8, 2024 10:33
@daschbot daschbot mentioned this pull request Feb 8, 2024
Merged
irmastnt added a commit that referenced this pull request Feb 9, 2024
@irmastnt
Merge branch 'main' into feature/dev-2995-add-form-to-update-restrict…
0b7e3ac 
…ed-view-settings-watermark-and

* main:
  feat(dsp-das): project menu items highlighting (DEV-3103) (#1444)
  feat(dsp-das): image settings (DEV-2995) (#1440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derschnee68 derschnee68 derschnee68 approved these changes

@domsteinbach domsteinbach Awaiting requested review from domsteinbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irmastnt @derschnee68