fix: list item delete (DEV-3267) #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derschnee68
requested changes
Feb 8, 2024
derschnee68
requested changes
Feb 9, 2024
| take(1), | ||
| switchMap(() => this.listIri$.pipe(map(listIri => this._store.dispatch(new DeleteListNodeAction(listIri))))) | ||
| ) | ||
| .pipe(switchMap(() => this._actions$.pipe(ofActionSuccessful(DeleteListNodeAction), take(1)))) |
There was a problem hiding this comment.
please stop using ofActionSuccessful all the time, as this.store.dispatch(new DeleteListNodeAction) returns it
Here
.pipe( take(1), switchMap(() => this.listIri$), switchMap(listIri => this._store.dispatch(new DeleteListNodeAction(listIri)) )
derschnee68
approved these changes
Feb 9, 2024
irmastnt
added a commit
that referenced
this pull request
Feb 13, 2024
…ed-view-settings-watermark-and * main: fix(dsp-das): image viewer padding, arrows style. Resource list name css adjustments (DEV-3276) (#1456) fix: loads all projects when membership dialog is opened (DEV-3268) (#1450) test: add projects, list and auth end to end tests (#1454) fix: add instrumentation to faro sdk (#1455) feat(dsp-app): image settings updates and fixes (DEV-2995) (#1451) fix: remove old "edit project" page url (#1452) chore(main): release 11.5.1 (#1449) chore: update dsp-js to v9.1.11 (#1447) chore(main): release 11.5.0 (#1442) fix: list item delete (DEV-3267) (#1446) # Conflicts: # apps/dsp-app/src/app/project/image-settings/image-settings.component.html # apps/dsp-app/src/app/project/image-settings/image-settings.component.scss # apps/dsp-app/src/app/project/image-settings/image-settings.component.ts # apps/dsp-app/src/app/project/image-settings/project-image-settings.ts # apps/dsp-app/src/assets/i18n/de.json # apps/dsp-app/src/assets/i18n/en.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-3267