refactor: remove unused code in ontology component #1472
Merged
+113
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irmastnt
approved these changes
Feb 16, 2024
| @@ -234,7 +224,13 @@ export class OntologyComponent extends ProjectBase implements OnInit, OnDestroy | |||
| }), | |||
| }); | |||
|
|
|||
| this.ontologyForm.valueChanges.subscribe(val => this.onValueChanged(val.ontology)); | |||
| this.ontologyForm.valueChanges.subscribe(val => { | |||
There was a problem hiding this comment.
add takeUntil(this.ngUnsubscribe)
# Conflicts: # apps/dsp-app/src/app/project/ontology/ontology.component.ts
irmastnt
added a commit
that referenced
this pull request
Feb 28, 2024
* main: refactor: remove unused code in ontology component (#1472) fix: image region comment field validation removed(DEV-3315) (#1487) chore(main): release 11.6.5 (#1486) fix: submit button on upload resource does not load indefinitely (#1485) chore(main): release 11.6.4 (#1482) # Conflicts: # apps/dsp-app/src/app/project/ontology/ontology.component.html # apps/dsp-app/src/app/project/ontology/ontology.component.ts
irmastnt
added a commit
that referenced
this pull request
Feb 28, 2024
…-regions-set-to-optional * main: test: e2e data model tests (DEV-2379, DEV-2341, DEV-2339, DEV-2338) (#1475) fix: removed absolute image size restriction, added sample image (DEV-3304) (#1484) refactor: remove unused code in ontology component (#1472) fix: image region comment field validation removed(DEV-3315) (#1487)
irmastnt
added a commit
that referenced
this pull request
Feb 28, 2024
…ighted-in-chrome-after-clicking * main: test: e2e data model tests (DEV-2379, DEV-2341, DEV-2339, DEV-2338) (#1475) fix: removed absolute image size restriction, added sample image (DEV-3304) (#1484) refactor: remove unused code in ontology component (#1472) fix: image region comment field validation removed(DEV-3315) (#1487) chore(main): release 11.6.5 (#1486) fix: submit button on upload resource does not load indefinitely (#1485) chore(main): release 11.6.4 (#1482) fix: ontology initialisation (DEV-3317) (#1483) fix: new list node field error is not displayed (#1481) chore(main): release 11.6.3 (#1470) chore: update dsp-js to v.9.1.12 (#1478) fix: highlits section by clicked region in image viewer (DEV-3277) (#1468)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-3301