refactor: forms using multi language inputs should be typed #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor-multi-language-inputs-and-textarea-should-use-typed
…ctor-forms-using-multi-language-inputs-should-be-typed # Conflicts: # apps/dsp-app/src/app/project/list/list-item-element/list-item-element.component.ts # apps/dsp-app/src/app/project/list/list-item-form/list-item-form.component.ts # apps/dsp-app/src/app/project/list/list-item-form/reusable-list-item-form.component.ts # apps/dsp-app/src/app/project/list/reusable-list-info-form/reusable-list-info-form.component.ts # apps/dsp-app/src/app/project/ontology/resource-class-form/resource-class-form.component.ts # apps/dsp-app/src/app/project/reusable-project-form/reusable-project-form.component.ts # libs/vre/shared/app-string-literal/src/index.ts
irmastnt
requested changes
Mar 1, 2024
| import { DaschLanguage } from './dash-language.type'; | ||
|
|
||
| export const DEFAULT_MULTILANGUAGE_FORM = ( | ||
| data: StringLiteralV2[] = [{ language: 'de', value: '' }], |
There was a problem hiding this comment.
- use enumerator or constants for language strings
- take default language from configuration
There was a problem hiding this comment.
pre-filling data is missing
irmastnt
approved these changes
Mar 1, 2024
derschnee68
deleted the
feature/dev-3355-refactor-forms-using-multi-language-inputs-should-be-typed
branch
irmastnt
added a commit
that referenced
this pull request
Mar 4, 2024
…-regions-set-to-optional * main: chore: cypress cloud only runs after release-please PR is merged (#1499) feat: resource state management (DEV-3358) (#1496) chore: run e2e tests after release please actions on cypress cloud (#1498) refactor: remove unused unit tests (#1497) refactor: forms using multi language inputs should be typed (#1494) fix(docs): fix dead links in docs (#1492) test: remove temporarily ontology tests (#1495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-3355