Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSP-293 Update contact information on the landing page #316

Merged
merged 2 commits into from Oct 12, 2020
Merged

DSP-293 Update contact information on the landing page #316

merged 2 commits into from Oct 12, 2020

Conversation

waychal
Copy link
Contributor

@waychal waychal commented Oct 9, 2020

On landing page, update contact information for:

  • email address with default subject
  • post address
  • phone number

resolves DSP-293

fix (landing page): update contact information
4100f71 
On landing page, update contact information for:
- email address with default subject
- post address
- phone number
@flavens flavens assigned flavens and waychal and unassigned flavens Oct 12, 2020
@flavens flavens added the refactor Refactor or redesign label Oct 12, 2020
flavens
flavens approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
One detail, you have to fill in the assignee and label sections of the PR - especially the label because we use it.them in the release notes (see contribution documentation). I did it for you here.

@waychal
Copy link
Contributor Author

waychal commented Oct 12, 2020

@flavens Thanks. I will do it from next time. I will merge the PR now.

@waychal waychal merged commit 06656a9 into master Oct 12, 2020
@waychal waychal deleted the fix/DSP-293-update-contact-info branch October 12, 2020 07:31
@waychal waychal restored the fix/DSP-293-update-contact-info branch October 14, 2020 10:37
RalfBarkow pushed a commit that referenced this pull request Nov 3, 2020
Merge branch 'main' into wip/DSP-815-Use-the-DSP-name
b95dd73 
* main:
  Update dependencies (#327)
  Update dsp dependencies (#326)
  DSP-920 Renaming default github branch to "main" (#325)
  DSP-908 - Project List Sorting Fix (#323)
  DSP-860: Ontology editor: Create resource class (#322)
  DSP-859 Create ontology (#319)
  feat(header+dialog): create button in the header + dialog box (#320)
  fix(node_modules): Update dependencies (#318)
  DSP-329 Fix sort button (#303)
  Update js-lib and ui-lib (#317)
  DSP-293 Update contact information on the landing page (#316)
@kilchenmann kilchenmann deleted the fix/DSP-293-update-contact-info branch February 12, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfBarkow RalfBarkow RalfBarkow left review comments

@flavens flavens flavens approved these changes

@kilchenmann kilchenmann Awaiting requested review from kilchenmann

Assignees

@waychal waychal

Labels
refactor Refactor or redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waychal @RalfBarkow @flavens